lkml.org 
[lkml]   [2017]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] DWARF: add the config option
On Sun, 7 May 2017, Josh Poimboeuf wrote:

> DWARF is great for debuggers. It helps you find all the registers on
> the stack, so you can see function arguments and local variables. All
> expressed in a nice compact format.
>
> But that's overkill for unwinders. We don't need all those registers,
> and the state machine is too complicated.

OTOH if we make the failures in processing of those "auxiliary"
information non-fatal (in a sense that it neither causes kernel bug nor
does it actually corrupt the unwinding process, but the only effect is
losing "optional" information), having this data available doesn't hurt.

It's there anyway for builds containing debuginfo, and the information is
all there so that it can be used by things like gdb or crash, so it seems
natural to re-use as much as possible of it.

> Unwinders basically only need to know one thing: given an instruction
> address and a stack pointer, where is the caller's stack frame?

Again, DWARF should be able to give us all of this (including the
FP-fallback etc). It feels a bit silly to purposedly ignore it and
reinvent parts of it again, instead of fixing (read: "asking toolchain
guys to fix") the cases where we actually are not getting the proper data
in DWARF. That's a win-win at the end of the day.

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2017-05-10 21:19    [W:0.176 / U:1.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site