lkml.org 
[lkml]   [2017]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show()
From
Date
On Tue, 2017-05-09 at 19:29 +0200, Noralf Trønnes wrote:
> Den 08.05.2017 13.54, skrev SF Markus Elfring:
> > A single character (line break) should be put into a sequence.
> > Thus use the corresponding function "seq_putc".

Markus, I know this is hard for you,
but think more before sending patches.

> > diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
[]
> > @@ -946,7 +946,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused)
> >
> > for (i = 0; i < len; i++)
> > seq_printf(m, "%02x", val[i]);
> > - seq_puts(m, "\n");
> > + seq_putc(m, '\n');

Use the %p<foo> extensions.

seq_printf(m, "%*phN\n", len, val)

\
 
 \ /
  Last update: 2017-05-10 21:19    [W:0.060 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site