Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code | Date | Tue, 9 May 2017 12:20:40 +0000 |
| |
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On 9-5-2017 7:33, Kalle Valo wrote: >> "Gustavo A. R. Silva" <garsilva@embeddedor.com> writes: >> >>> The name of an array used by itself will always return the array's address. >>> So these tests will always evaluate as false and therefore the _return_ >>> will never be executed. >>> >>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> >> I don't understand the commit log, especially what does "The name of an >> array used by itself" mean? > > The array fields in struct wmi_start_scan_arg that are checked here are > fixed size arrays so they can never be NULL. > > Maybe that helps rephrasing this commit message.
Much much better, thanks!
-- Kalle Valo
| |