lkml.org 
[lkml]   [2017]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] drm/sti: use seq_puts to display a string
2017-03-31 21:25 GMT+02:00 Nicolas Iooss <nicolas.iooss_linux@m4x.org>:
> gdp_dbg_ctl() uses seq_printf() to display a color format name even
> though there is no format string. When using -Wformat-string, gcc
> reports the following warning:
>
> drivers/gpu/drm/sti/sti_gdp.c: In function 'gdp_dbg_ctl':
> drivers/gpu/drm/sti/sti_gdp.c:150:18: warning: format not a string
> literal and no format arguments [-Wformat-security]
> seq_printf(s, gdp_format_to_str[i].name);
> ^~~~~~~~~~~~~~~~~
>
> Silence this warning by using seq_puts() instead.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> drivers/gpu/drm/sti/sti_gdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
> index 86279f5022c2..1bbfcf01d401 100644
> --- a/drivers/gpu/drm/sti/sti_gdp.c
> +++ b/drivers/gpu/drm/sti/sti_gdp.c
> @@ -147,7 +147,7 @@ static void gdp_dbg_ctl(struct seq_file *s, int val)
> seq_puts(s, "\tColor:");
> for (i = 0; i < ARRAY_SIZE(gdp_format_to_str); i++) {
> if (gdp_format_to_str[i].format == (val & 0x1F)) {
> - seq_printf(s, gdp_format_to_str[i].name);
> + seq_puts(s, gdp_format_to_str[i].name);
> break;
> }
> }
> --
> 2.11.1
>

Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

\
 
 \ /
  Last update: 2017-05-10 21:18    [W:0.023 / U:4.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site