Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] key: Convert big_key payload.data to struct | Date | Tue, 09 May 2017 09:11:24 +0100 |
| |
Kees Cook <keescook@chromium.org> wrote:
> This doesn't protect you against changes in struct path size, > though... the existing code (and this proposal) will break if that > ever happens...
True - in which case you should kmalloc() it as Eric suggests.
> What's the problem with defining the types at the top level? That > seems like a nice place to see them all at once.
It means adding a bunch of dependencies to linux/key.h and union key_payload.
Have you considered why we don't just put all the definitions for all the filesystems in linux/fs.h? By this logic it would seem like a nice place to see them all at once.
David
| |