Messages in this thread | | | Date | Tue, 9 May 2017 11:01:41 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging : rtl8188eu : remove unnecessary else |
| |
On Mon, May 08, 2017 at 02:13:00PM +0530, Surender Polsani wrote: > according to coding style else is not generally > useful after a break or return > > Signed-off-by: Surender Polsani <surenderpolsani@gmail.com> > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > index d04b7fb..7420f55 100644 > --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > @@ -212,8 +212,7 @@ u8 rtw_hal_antdiv_before_linked(struct adapter *Adapter) > > rtw_antenna_select_cmd(Adapter, dm_swat_tbl->CurAntenna, false); > return true; > - } else { > + } > dm_swat_tbl->SWAS_NoLink_State = 0; > return false; > - }
Nope.
I think you really need to learn C programming before you send any more patches.
regards, dan carpenter
| |