lkml.org 
[lkml]   [2017]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V15 10/11] trace, ras: add ARM processor error trace event
    On Tue, Apr 18, 2017 at 05:05:22PM -0600, Tyler Baicar wrote:
    > Currently there are trace events for the various RAS
    > errors with the exception of ARM processor type errors.
    > Add a new trace event for such errors so that the user
    > will know when they occur. These trace events are
    > consistent with the ARM processor error section type
    > defined in UEFI 2.6 spec section N.2.4.4.
    >
    > Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
    > Acked-by: Steven Rostedt <rostedt@goodmis.org>
    > Reviewed-by: Xie XiuQi <xiexiuqi@huawei.com>
    > ---
    > drivers/acpi/apei/ghes.c | 8 +++++++-
    > drivers/firmware/efi/cper.c | 1 +
    > drivers/ras/ras.c | 1 +
    > include/ras/ras_event.h | 45 +++++++++++++++++++++++++++++++++++++++++++++
    > 4 files changed, 54 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
    > index 3d9f63b..612deb3 100644
    > --- a/drivers/acpi/apei/ghes.c
    > +++ b/drivers/acpi/apei/ghes.c
    > @@ -518,7 +518,13 @@ static void ghes_do_proc(struct ghes *ghes,
    > }
    > #endif
    > #ifdef CONFIG_RAS
    > - else if (trace_unknown_sec_event_enabled()) {
    > + else if (!uuid_le_cmp(sec_type, CPER_SEC_PROC_ARM) &&
    > + trace_arm_event_enabled()) {
    > + struct cper_sec_proc_arm *arm_err;
    > +
    > + arm_err = acpi_hest_get_payload(gdata);
    > + trace_arm_event(arm_err);
    > + } else if (trace_unknown_sec_event_enabled()) {
    > void *unknown_err = acpi_hest_get_payload(gdata);
    >
    > trace_unknown_sec_event(&sec_type,

    As with the previous patch, move that code to ras.c so that you can get rid of
    the ifdeffery here.

    --
    Regards/Gruss,
    Boris.

    Good mailing practices for 400: avoid top-posting and trim the reply.

    \
     
     \ /
      Last update: 2017-05-08 19:35    [W:5.083 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site