lkml.org 
[lkml]   [2017]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sky2: Use seq_putc() in sky2_debug_show()
From
Date
Hi,

On 08.05.2017 18:42, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 18:38:17 +0200
>
> A single character (line break) should be put into a sequence.

Why?

> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.

Which issue do you mean? I dont see any issue you fix here.

>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/net/ethernet/marvell/sky2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
> index 1145cde2274a..73575101cd72 100644
> --- a/drivers/net/ethernet/marvell/sky2.c
> +++ b/drivers/net/ethernet/marvell/sky2.c
> @@ -4562,7 +4562,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
> seq_printf(seq, "[%d] %#x %d %#x\n",
> idx, le->opcode, le->length, le->status);
> }
> - seq_puts(seq, "\n");
> + seq_putc(seq, '\n');
> }
>
> seq_printf(seq, "Tx ring pending=%u...%u report=%d done=%d\n",
>

Regards,
Lino

\
 
 \ /
  Last update: 2017-05-08 19:09    [W:0.893 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site