Messages in this thread | | | Date | Mon, 8 May 2017 13:30:52 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf probe: Fix examples section of documentation |
| |
Em Tue, May 09, 2017 at 12:19:57AM +0900, Masami Hiramatsu escreveu: > On Sun, 7 May 2017 19:36:42 +0900 > SeongJae Park <sj38.park@gmail.com> wrote: > > > An example in perf-probe documentation for pattern of function name > > based probe addition is not providing example command for the case. > > This commit fixes the example to give appropriate example command. > > > > Signed-off-by: SeongJae Park <sj38.park@gmail.com> > > Good catch! > > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks, I added the suggested Fixes: tag,
- Arnaldo
> Thank you! > > > --- > > tools/perf/Documentation/perf-probe.txt | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt > > index e6c9902c6d82..165c2b1d4317 100644 > > --- a/tools/perf/Documentation/perf-probe.txt > > +++ b/tools/perf/Documentation/perf-probe.txt > > @@ -240,9 +240,13 @@ Add a probe on schedule() function 12th line with recording cpu local variable: > > or > > ./perf probe --add='schedule:12 cpu' > > > > - this will add one or more probes which has the name start with "schedule". > > +Add one or more probes which has the name start with "schedule". > > > > - Add probes on lines in schedule() function which calls update_rq_clock(). > > + ./perf probe schedule* > > + or > > + ./perf probe --add='schedule*' > > + > > +Add probes on lines in schedule() function which calls update_rq_clock(). > > > > ./perf probe 'schedule;update_rq_clock*' > > or > > -- > > 2.12.0 > > > > > -- > Masami Hiramatsu <mhiramat@kernel.org>
| |