Messages in this thread | | | Date | Mon, 08 May 2017 10:44:27 -0500 | From | "Gustavo A. R. Silva" <> | Subject | Re: [PATCH] net: ipv4: add code comment for clarification |
| |
Hi David,
Quoting David Miller <davem@davemloft.net>:
> From: "Gustavo A. R. Silva" <garsilva@embeddedor.com> > Date: Thu, 4 May 2017 14:44:16 -0500 > >> @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, >> struct sk_buff *skb, >> nlmsg_flags, unlh, net_admin); >> } >> >> +/* >> + * Ignore the position of the arguments req->id.idiag_dport and >> + * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup() >> + * functions, once this is a locked in behavior exposed to user space. >> + * Changing this will break things for people. >> + */ > > This is implicit for every interface exposed to userspace. > > Therefore, saying it here and there in various comments provides > questionable value. > > And in fact I think these arguments are probably in the correct order. > > I'm definitely not applying a patch like this, sorry.
I get it, thanks for clarifying. -- Gustavo A. R. Silva
| |