lkml.org 
[lkml]   [2017]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH] net: dsa: loop: Check for memory allocation failure


On Mon, 8 May 2017, David Laight wrote:

> From: Christophe JAILLET
> > Sent: 06 May 2017 06:30
> > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
> > Return -ENOMEM instead, as done for some other memory allocation just a
> > few lines above.
> ...
> > --- a/drivers/net/dsa/dsa_loop.c
> > +++ b/drivers/net/dsa/dsa_loop.c
> > @@ -256,6 +256,9 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
> > return -ENOMEM;
> >
> > ps = devm_kzalloc(&mdiodev->dev, sizeof(*ps), GFP_KERNEL);
> > + if (!ps)
> > + return -ENOMEM;
> > +
> > ps->netdev = dev_get_by_name(&init_net, pdata->netdev);
> > if (!ps->netdev)
> > return -EPROBE_DEFER;
>
> On the face if it this code leaks like a sieve.

I don't think so. The allocations (dsa_switch_alloc and devm_kzalloc) use
devm functions.

julia

\
 
 \ /
  Last update: 2017-05-08 14:33    [W:0.886 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site