lkml.org 
[lkml]   [2017]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional
From
Date
On Fri, 2017-05-05 at 16:10 -0600, Justin Vreeland wrote:
>
<snip>
> Sorry about blank email.
>
> I'm not 100% happy with it either.  Larry Finger suggested to fix the
> overly long lines so I tried to find a decent way to shorten them.  I
> think the best way would be to change the function names or pull the
> function
> calls out of the if statements.
>
> If these line breaks aren't a good solution and keeping them over 80
> isn't either I'd
> rather drop this patch from the set if that's okay.

Dropping the sections of this patch that require linefeeds in the
middle of if statements would be fine by me. I don't think that a brace
on the next line is worse than splitting a condition on 2 lines.

Cheers

\
 
 \ /
  Last update: 2017-05-06 11:33    [W:0.048 / U:20.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site