lkml.org 
[lkml]   [2017]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] firmware: Google VPD: Fix memory allocation error handling
From
Date
Le 05/05/2017 à 21:56, Greg KH a écrit :
> On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
>> This patch fixes several issues:
>> - if the 1st 'kzalloc' fails, we dereference a NULL pointer
>> - if the 2nd 'kzalloc' fails, there is a memory leak
>> - if 'sysfs_create_bin_file' fails there is also a memory leak
> Then it should be multiple patches, not fixing 3 things in one patch,
> right?
>
> thanks,
>
> greg k-h
>
I can split it if you want, but the 3 points are more or less related
and all belong to the same few lines of code. I didn't think having 3
patches was needed in this case. I just wanted to give a detailed changelog.
If the commit message was only "This patch fixes memory allocation error
handling in fct xxx' (as in the topic), I guess it would has been
accepted (if it is correct of course) as-is.

Just tell me if you really prefer 3 patches, and I will resubmit.

CJ

\
 
 \ /
  Last update: 2017-05-06 07:02    [W:0.166 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site