Messages in this thread | | | From | Moritz Fischer <> | Date | Fri, 5 May 2017 10:08:11 -0700 | Subject | Re: [PATCH v2 06/16] fpga: region: remove unneeded of_node_get and put |
| |
On Thu, Apr 20, 2017 at 7:09 AM, Alan Tull <atull@kernel.org> wrote: > Remove of_node_get/put in fpga_region_get/put. Not > needed and will get in the way when I separate out > the common FPGA region code from Device Tree support > code. > > Signed-off-by: Alan Tull <atull@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org> > --- > v2: split out from another patch > --- > drivers/fpga/fpga-region.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c > index eaea9d4..6784357 100644 > --- a/drivers/fpga/fpga-region.c > +++ b/drivers/fpga/fpga-region.c > @@ -94,9 +94,7 @@ static struct fpga_region *fpga_region_get(struct fpga_region *region) > } > > get_device(dev); > - of_node_get(dev->of_node); > if (!try_module_get(dev->parent->driver->owner)) { > - of_node_put(dev->of_node); > put_device(dev); > mutex_unlock(®ion->mutex); > return ERR_PTR(-ENODEV); > @@ -119,7 +117,6 @@ static void fpga_region_put(struct fpga_region *region) > dev_dbg(dev, "put\n"); > > module_put(dev->parent->driver->owner); > - of_node_put(dev->of_node); > put_device(dev); > mutex_unlock(®ion->mutex); > } > -- > 2.7.4 >
| |