Messages in this thread | | | Date | Fri, 5 May 2017 14:30:35 +0200 | From | Maxime Ripard <> | Subject | Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for V3s SoC |
| |
On Fri, May 05, 2017 at 04:53:43PM +0800, icenowy@aosc.io wrote: > > > + de2_clocks: clock@1000000 { > > > + compatible = "allwinner,sun50i-h5-de2-clk"; > > > > I am a bit skeptical about this. Since the V3S only has one mixer, do > > the clocks > > for the second one even exist? > > It's described in the de_clock.c in the BSP source code, and in hardware > these bits can be really set (although without clock output). > > So I use this compatible which has still the extra clocks.
If it's not usable, then it shouldn't be in the code, it's basically dead code.
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |