Messages in this thread | | | Date | Thu, 4 May 2017 11:03:34 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v1] vmbus: Reuse uuid_le_to_bin() helper |
| |
On Wed, May 03, 2017 at 08:19:22PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-03 at 20:07 +0300, Andy Shevchenko wrote: > > Instead of open coded variant use generic helper to convert UUID > > strings > > to binary format. > > > @@ -677,12 +644,14 @@ static ssize_t remove_id_store(struct > > device_driver *driver, const char *buf, > > { > > struct hv_driver *drv = drv_to_hv_drv(driver); > > struct vmbus_dynid *dynid, *n; > > > > > - size_t retval = -ENODEV; > > > > + ssize_t retval; > > Just noticed, I'm fixing a bug here as well.
It doesn't affect runtime. You can store negatives in unsigned types so long as they're uint or larger.
regards, dan carpenter
| |