lkml.org 
[lkml]   [2017]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging
Date
Paolo Bonzini <pbonzini@redhat.com> writes:

> On 04/05/2017 00:14, Bandan Das wrote:
>> + if (vmx->nested.pml_full) {
>> + exit_reason = EXIT_REASON_PML_FULL;
>> + vmx->nested.pml_full = false;
>> + } else if (fault->error_code & PFERR_RSVD_MASK)
>> exit_reason = EXIT_REASON_EPT_MISCONFIG;
>> else
>> exit_reason = EXIT_REASON_EPT_VIOLATION;
>> + /*
>> + * The definition of bit 12 for EPT violations and PML
>> + * full event is the same, so pass it through since
>> + * the rest of the bits are undefined.
>> + */
>
> Please zero all other bits instead. It's as easy as adding an "u64
> exit_qualification" local variable.

Will do, thanks for the review.

Bandan

> Paolo
>
>> nested_vmx_vmexit(vcpu, exit_reason, 0, vcpu->arch.exit_qualification);

\
 
 \ /
  Last update: 2017-05-04 20:15    [W:0.036 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site