lkml.org 
[lkml]   [2017]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [net-ipv4] question about arguments position
    From
    Date
    On Thu, 2017-05-04 at 12:46 -0400, David Miller wrote:
    > From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
    > Date: Thu, 04 May 2017 11:07:54 -0500
    >
    > > While looking into Coverity ID 1357474 I ran into the following piece
    > > of code at net/ipv4/inet_diag.c:392:
    >
    > Because it's been this way since at least 2005, it doesn't matter if
    > the order is correct or not.  What's there is the locked in behavior
    > exposed to userspace and changing it will break things for people.

    Adding a few comments around the code about why
    it is this way will help avoid future questions.

    \
     
     \ /
      Last update: 2017-05-04 19:49    [W:3.402 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site