lkml.org 
[lkml]   [2017]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/4] PCI: add functionality for resizing resources v3
On Thu, May 4, 2017 at 1:15 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, May 4, 2017 at 12:23 PM, Christian König
> <deathsimple@vodafone.de> wrote:
>> Am 26.04.2017 um 19:00 schrieb Andy Shevchenko:

> static int ...xxx...(...)
> {
> unsigned int i;
> int ret;
>

> if (res->parent)
> release_resource(res);
>

dev_info() should be here. I commented on this earlier, just forgot.

> res->start = 0;
> res->end = 0;
> dev_info(&bridge->dev, "BAR %d: released %pR\n", i, res);
> return i;
> }
>
>
> struct pci_dev *next = bridge;
> ...
> do {
> bridge = next;
>
> ret = ...xxx...(...);

> if (ret)

Here, of course,

if (ret < 0)

> goto cleanup;
>
> next = bridge->bus ? bridge->bus->self : NULL;
> } while (next);


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-05-04 18:44    [W:0.267 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site