lkml.org 
[lkml]   [2017]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver
From


于 2017年5月4日 GMT+08:00 下午10:02:20, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
>On Thu, May 04, 2017 at 09:49:59PM +0800, Icenowy Zheng wrote:
>> static const struct of_device_id sun4i_a10_pinctrl_match[] = {
>> - { .compatible = "allwinner,sun4i-a10-pinctrl", },
>> + {
>> + .compatible = "allwinner,sun4i-a10-pinctrl",
>> + .data = (void *)PINCTRL_SUN4I_A10
>> + },
>> + {
>> + .compatible = "allwinner,sun7i-a20-pinctrl",
>> + .data = (void *)PINCTRL_SUN7I_A20
>> + },
>> {}
>> };
>
>This means you're going to have two drivers probing for the same
>device: this driver, and the old one. This is not ok, and probably
>introduces some corner cases.

The A20 driver is dropped in the next commit.

>
>Maxime

\
 
 \ /
  Last update: 2017-05-04 16:04    [W:0.210 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site