lkml.org 
[lkml]   [2017]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
On Thu, May 04, 2017 at 12:16:20AM +0200, Alexandre Belloni wrote:
> On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote:
> > On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> > > The rv4162 vendor is microcrystal, not ST.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> > > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > index bad3c9f9eeac..b63134e3b51a 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > @@ -408,7 +408,7 @@
> > > };
> > >
> > > rtc: rtc@68 {
> > > - compatible = "st,rv4162";
> > > + compatible = "microcrystal,rv4162";
> >
> > The compatible is not documented?
> >
>
> No, it wasn't. Like for many i2c devices, the driver predates DT and
> didn't need any specific code to be used from DT. Basically, the i2c
> core was using the i2c_device_ids to match the DT compatible string.
> This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811.
>
> I'm planning to document all the undocumented ones soon.

I applied all 3 patches. Please remember to document the compatible.

Shawn

\
 
 \ /
  Last update: 2017-05-04 15:18    [W:1.541 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site