Messages in this thread | | | Subject | Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses | From | Bastien Nocera <> | Date | Thu, 04 May 2017 13:30:45 +0200 |
| |
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: > Enclosing macros with complex values ensures expression is evaluated > as > expected. > > Signed-off-by: Justin Vreeland <justin@jvreeland.com> > --- > v2: > - Added spaces around plus signs > - Fixed line over 80 columns > - Added commit message > > drivers/staging/rtl8723bs/hal/odm.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/odm.h > b/drivers/staging/rtl8723bs/hal/odm.h > index 0b3541a91548..87a76bafecb3 100644 > --- a/drivers/staging/rtl8723bs/hal/odm.h > +++ b/drivers/staging/rtl8723bs/hal/odm.h > @@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE { > > #define AVG_THERMAL_NUM 8 > #define IQK_Matrix_REG_NUM 8 > -#define IQK_Matrix_Settings_NUM 14+24+21 > /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */ > +#define IQK_Matrix_Settings_NUM (14 + 24 + 21) > /* Channels_2_4G_NUM > + * + > Channels_5G_20M_NUM > + * + Channels_5G > + */
This does line up when applied, right? If so: Reviewed-by: Bastien Nocera <hadess@hadess.net>
| |