| Date | Wed, 31 May 2017 15:07:29 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH V1 15/15] spmi: pmic-arb: instantiate spmi_devices at arch_initcall |
| |
On 05/30, Kiran Gunda wrote: > @@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev) > .of_match_table = spmi_pmic_arb_match_table, > }, > }; > -module_platform_driver(spmi_pmic_arb_driver); > + > +int __init spmi_pmic_arb_init(void)
Missing static.
> +{ > + return platform_driver_register(&spmi_pmic_arb_driver); > +} > +arch_initcall(spmi_pmic_arb_init);
We also lost module removal. Probably nobody tests it, but still no mention of that in commit text.
I'm not sure we need this at all though. Is there something that needs to probe early? Indicating what that is in the commit text would be helpful.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
|