Messages in this thread | | | Date | Wed, 31 May 2017 19:28:34 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] regmap: Add 1-Wire bus support |
| |
On Tue, May 30, 2017 at 08:57:33PM +0300, Alex A. Mihaylov wrote:
> + if (!w1_reset_select_slave(sl)) { > + w1_write_8(sl->master, W1_CMD_READ_DATA); > + w1_write_8(sl->master, reg); > + *val = w1_read_8(sl->master); > + } else > + ret = -ENODEV;
CodingStyle says { } on both sides of an if statement if they're on one. Otherwise this looks good. [unhandled content-type:application/pgp-signature] | |