lkml.org 
[lkml]   [2017]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/4] Documentation: dt: iio: at91-sama5d2_adc: add adtrg trigger binding
On Thu, May 25, 2017 at 02:17:12PM +0300, Eugen Hristev wrote:
> Add node information for ADTRG hardware pin and the three possible
> edge nodes that are available for the driver
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> .../devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> index 3223684..e30ede3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> @@ -11,6 +11,13 @@ Required properties:
> - atmel,min-sample-rate-hz: Minimum sampling rate, it depends on SoC.
> - atmel,max-sample-rate-hz: Maximum sampling rate, it depends on SoC.
> - atmel,startup-time-ms: Startup time expressed in ms, it depends on SoC.
> + - atmel,trigger-edge-type: phandle to one of the adtrg possible edge types
> +
> +Required adtrg node:
> + - Required edge nodes:
> + For each possible edge type for the ADTRG hardware trigger pin,
> + a specific sub node. The driver recognises only the three possible
> + edge types: external_rising, external_falling, external_any.

Why is this not just a simple property? Having 4 nodes just for this is
pointless.

>
> Example:
>
> @@ -25,4 +32,14 @@ adc: adc@fc030000 {
> atmel,startup-time-ms = <4>;
> vddana-supply = <&vdd_3v3_lp_reg>;
> vref-supply = <&vdd_3v3_lp_reg>;
> + atmel,trigger-edge-type = <&external_rising>;
> +
> + adtrg: adtrg {
> + external_rising: external_rising {
> + };
> + external_falling: external_falling {
> + };
> + external_any: external_any {
> + };
> + };
> }
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

\
 
 \ /
  Last update: 2017-05-31 20:03    [W:0.080 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site