lkml.org 
[lkml]   [2017]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support
    Hi Daniel,

    On Thu, May 25, 2017 at 10:54:55PM +0200, Daniel Lezcano wrote:
    > On Sat, May 13, 2017 at 03:29:35PM +0800, Dong Aisheng wrote:
    > > IMX Timer/PWM Module (TPM) supports both timer and pwm function while
    > > this patch only adds the timer support. PWM would be added later.
    > >
    > > The TPM counter, compare and capture registers are clocked by an
    > > asynchronous clock that can remain enabled in low power modes.
    > >
    > > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
    > > Cc: Thomas Gleixner <tglx@linutronix.de>
    > > Cc: Shawn Guo <shawnguo@kernel.org>
    > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
    > > Signed-off-by: Bai Ping <ping.bai@nxp.com>
    > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
    > > ---
    >
    > [ ... ]
    >
    > > + val = __raw_readl(timer_base + TPM_C0SC);
    > > + val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
    > > + __raw_writel(val, timer_base + TPM_C0SC);
    >
    > Hi Dong,
    >
    > why are you using __raw_write/__raw_read instead of regular readl/writel?
    >

    Sorry for missing the second throught of it.

    Will change to readl/writel as Arnd pointed out in another mail.

    Regards
    Dong Aisheng

    \
     
     \ /
      Last update: 2017-05-31 08:36    [W:2.422 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site