Messages in this thread | | | From | Vitaly Kuznetsov <> | Subject | Re: [PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor | Date | Wed, 31 May 2017 16:38:43 +0200 |
| |
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Tue, 30 May 2017 13:34:16 +0200 > Vitaly Kuznetsov <vkuznets@redhat.com> wrote: > >> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c >> index 04cb8d3..bdcc433 100644 >> --- a/arch/x86/kernel/cpu/mshyperv.c >> +++ b/arch/x86/kernel/cpu/mshyperv.c >> @@ -175,9 +175,15 @@ static void __init ms_hyperv_init_platform(void) >> ms_hyperv.misc_features = cpuid_edx(HYPERV_CPUID_FEATURES); >> ms_hyperv.hints = cpuid_eax(HYPERV_CPUID_ENLIGHTMENT_INFO); >> >> - pr_info("HyperV: features 0x%x, hints 0x%x\n", >> + pr_info("Hyper-V: features 0x%x, hints 0x%x\n", >> ms_hyperv.features, ms_hyperv.hints); > >> >> + ms_hyperv.max_vp_index = cpuid_eax(HVCPUID_IMPLEMENTATION_LIMITS); >> + ms_hyperv.max_lp_index = cpuid_ebx(HVCPUID_IMPLEMENTATION_LIMITS); >> + >> + pr_info("Hyper-V: max %u virtual processors, %u logical processors\n", >> + ms_hyperv.max_vp_index, ms_hyperv.max_lp_index); >> + > > I understand as developer why you may need to log stuff. > Do we really need more logging here? Why not pr_debug()?
Agreed, lets do pr_debug() instead.
-- Vitaly
| |