Messages in this thread | | | Subject | Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID | From | Joe Perches <> | Date | Tue, 30 May 2017 12:17:22 -0700 |
| |
On Tue, 2017-05-30 at 22:04 +0300, Andy Shevchenko wrote: > On Tue, 2017-05-30 at 10:23 -0700, Joe Perches wrote: > > On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > > > > > > Or we'd need to introduce %pH I guess. > > > > As it's debugging output, I'd hazard to guess it doesn't matter. > > > > If someone _really_ needs upper-case output in *ph, > > Starting from the same... > > > > A pity that %ph[cdnCDN] isn't possible as that's the style used > > by %pU[blBL] for lower/upper case output. > > > > There are < 80 uses of %[\*\d]+ph[CDN], maybe it'd be reasonable > > to do a treewide sed to lowercase for them. Dunno.
It's more like ~300 when the grep is done properly, -E needed to be -P, so I believe that's too many to bother with a treewide sed.
> And I think less intrusive would be > %pH[CDN] > since the latter proposal misses plain %*ph use.
No it wouldn't necessarily. %*phU could still be upper case too.
> But for now I would rather avoid it at all, I'm pretty sure there very > rare cases when one needs > 1) to print a dump, *and* > 2) it should be upper cased.
Doubtful, but maybe there is a seq_ use somewhere that could be converted.
Anyway I think the proposed change in the original patch is fine and nothing else needs to be done.
| |