Messages in this thread | | | Subject | Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv | From | Florian Fainelli <> | Date | Tue, 30 May 2017 12:03:08 -0700 |
| |
Hey Vivien,
On 05/30/2017 11:33 AM, Vivien Didelot wrote: > The struct dsa_device_ops defines the rcv function with 2 unused > arguments struct packet_type *pt, and struct net_device *orig_dev. > > This patch removes them from the definition and implementations. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
I actually have a patch pending that adds support for HW insertion/extraction of switch tags (broadcom HW supports that) which require the orig_dev to be there so we know what features are supported by the master network device.
Do you mind dropping this one from your patch series?
Thanks! -- Florian
| |