Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 30 May 2017 21:59:05 +0300 | Subject | Re: [PATCH v2 6/7] gpio: mockup: improve the error message |
| |
On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: > Indicate the error number and make the message a bit more elaborate.
> + dev_err(dev, > + "adding gpiochip failed: %d (base: %d, ngpio: %d)\n", > + ret, base, base < 0 ? ngpio : base + ngpio);
You may consider to use 'gpio_mockup_add' instead of 'adding gpiochip'. The latter points the reader first to gpiochip_add family of functions while you run a wrapper on top of it.
-- With Best Regards, Andy Shevchenko
| |