lkml.org 
[lkml]   [2017]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] dt-bindings: interrupt-controller: add DT binding for the Marvell ICU
Hello,

Thanks for the quick review!

On Tue, 30 May 2017 11:37:10 +0100, Marc Zyngier wrote:

> > + The 1st cell is the group type of the ICU interrupt (SPI_NSR,
> > + SPI_SR, SEI, and REI).
>
> Is it worth documenting what these are?

Sure, will do.

> > +icu: interrupt-controller@1e0000 {
> > + compatible = "marvell,icu";
> > + reg = <0x1e0000 0x10>;
> > + #interrupt-cells = <2>;
>
> Oh wait...

Gaah, I did spot this mistake, but then forgot to fix it. Will do.

> > + interrupt-controller;
> > + interrupt-parent = <&gic>;
> > + gicp = <&gicp>;
>
> Should this be prefixed with a vendor specific identifier, just in case?

Would marvell,gicp be preferable?

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2017-05-30 13:43    [W:0.101 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site