lkml.org 
[lkml]   [2017]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ALSA: sound/core/pcm_timer.c: include pcm_local.h and remove some extraneous tabs
From
Date
On Tue, 2017-05-30 at 10:58 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We need to include pcm_local.h to clean up some smatch warnings:
>
> symbol 'snd_pcm_timer_done' was not declared. Should it be static?
> symbol 'snd_pcm_timer_init' was not declared. Should it be static?
> symbol 'snd_pcm_timer_resolution_change' was not declared. Should
> it be static?
>
> Also remove some extraneous tabs on empty lines.

Thanks. trivia:

> diff --git a/sound/core/pcm_timer.c b/sound/core/pcm_timer.c
[]
> @@ -33,7 +35,7 @@ void snd_pcm_timer_resolution_change(struct snd_pcm_substream *substream)
> {
> unsigned long rate, mult, fsize, l, post;
> struct snd_pcm_runtime *runtime = substream->runtime;
> -
> +
> mult = 1000000000;
> rate = runtime->rate;

Maybe fix the mult indentation too?

\
 
 \ /
  Last update: 2017-05-30 12:23    [W:0.033 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site