Messages in this thread | | | Subject | Re: [PATCH] ALSA: sound/core/pcm_timer.c: include pcm_local.h and remove some extraneous tabs | From | Joe Perches <> | Date | Tue, 30 May 2017 03:22:33 -0700 |
| |
On Tue, 2017-05-30 at 10:58 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > We need to include pcm_local.h to clean up some smatch warnings: > > symbol 'snd_pcm_timer_done' was not declared. Should it be static? > symbol 'snd_pcm_timer_init' was not declared. Should it be static? > symbol 'snd_pcm_timer_resolution_change' was not declared. Should > it be static? > > Also remove some extraneous tabs on empty lines.
Thanks. trivia:
> diff --git a/sound/core/pcm_timer.c b/sound/core/pcm_timer.c [] > @@ -33,7 +35,7 @@ void snd_pcm_timer_resolution_change(struct snd_pcm_substream *substream) > { > unsigned long rate, mult, fsize, l, post; > struct snd_pcm_runtime *runtime = substream->runtime; > - > + > mult = 1000000000; > rate = runtime->rate;
Maybe fix the mult indentation too?
| |