lkml.org 
[lkml]   [2017]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ALSA: declare snd_kcontrol_new structures as const
    On Sat, 27 May 2017 16:46:15 +0200,
    Bhumika Goyal wrote:
    >
    > Declare snd_kcontrol_new structures as const as they are only passed an
    > argument to the function snd_ctl_new1. This argument is of type const,
    > so snd_kcontrol_new structures having this property can be made const.
    > Done using Coccinelle:
    >
    > @r disable optional_qualifier@
    > identifier x;
    > position p;
    > @@
    > static struct snd_kcontrol_new x@p={...};
    >
    > @ok@
    > identifier r.x;
    > position p;
    > @@
    > snd_ctl_new1(&x@p,...)
    >
    > @bad@
    > position p != {r.p,ok.p};
    > identifier r.x;
    > @@
    > x@p
    >
    > @depends on !bad disable optional_qualifier@
    > identifier r.x;
    > @@
    > +const
    > struct snd_kcontrol_new x;
    >
    > Cross compiled these files:
    > sound/aoa/codecs/tas.c - powerpc
    > sound/mips/{hal2.c/sgio2audio.c} - mips
    > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
    > sound/soc/sh/siu_dai.c - sh
    > Could not find an architecture to compile sound/sh/aica.c.
    >
    > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

    Applied now, as it looks safe enough. But I prefer splitting to
    individual patches, so please try to do that at the next time.


    thanks,

    Takashi

    \
     
     \ /
      Last update: 2017-05-30 10:54    [W:5.634 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site