Messages in this thread | | | Date | Mon, 29 May 2017 21:47:11 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH 2/2] Input: pm8941-pwrkey: Introduce reboot mode support |
| |
On Mon 29 May 19:53 PDT 2017, Dmitry Torokhov wrote:
> On Fri, May 26, 2017 at 11:51:30PM -0700, Bjorn Andersson wrote: > > In some Qualcomm platforms the magic for informing LK which mode to > > reboot into is stored in the PON_SOFT_RB_SPARE register. Register with > > the reboot mode helpers to expose this to the user. > > Hmm, is the power key driver the best place to have this? WHy isn't this > a driver in its own right? >
The functionality is part of the "PON" block in the Qualcomm PMICs, other functionality from this block relates to configuration and handling related to power-key and reset-key.
Several of these properties are intermingled, so I do believe it's best to handle them in a single driver; that said, it might no longer be correct to name the driver "pwrkey" or that it is a "misc input" driver.
Regards, Bjorn
| |