Messages in this thread | | | From | Markus Mayer <> | Date | Wed, 3 May 2017 15:29:10 -0700 | Subject | Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors |
| |
Hi Rob,
On 27 April 2017 at 15:00, Florian Fainelli <f.fainelli@gmail.com> wrote: > On 04/27/2017 02:57 PM, Rob Herring wrote: >>>>> +Optional properties: >>>>> + - cell-index: the index of the DPFE instance; will default to 0 if not set >> >> Don't use cell-index. It's not a valid property for FDT (only real >> OpenFirmware). > > My bad, I was advising Markus to use this property since it was largely > used throughout Documentation/devicetree/bindings/. What would be a more > appropriate way to have the same information? Aliases?
Hopefully this will be the last time we need to pester you about this. What should we be using instead of cell-index to identify multiple instances of a device?
To give you an idea of what the code looks like right now:
ret = of_property_read_u32(dev->of_node, "cell-index", &index); if (ret) index = 0; [...] dev_set_name(dpfe_dev, "dpfe%u", index); ret = device_register(dpfe_dev);
Enumerating the devices like this is what we are after.
Thanks, -Markus
| |