Messages in this thread | | | Subject | Re: [PATCH v7 00/34] i.MX Media Driver | From | Hans Verkuil <> | Date | Mon, 29 May 2017 19:29:33 +0200 |
| |
On 05/29/2017 07:23 PM, Steve Longerbeam wrote: > Hi Hans, thanks for the reply... > > > On 05/29/2017 06:46 AM, Hans Verkuil wrote: >> Hi Steve, >> >> On 05/25/2017 02:29 AM, Steve Longerbeam wrote: >>> In version 7: >>> >>> >> >> What is the status as of v7? >> >> From what I can tell patch 2/34 needs an Ack from Rob Herring, > > > Yes still missing that Ack. I think the issue is likely the Synopsys DW > mipi csi-2 bindings. Someone earlier noted that there is another driver > under devel for this Synopsys core, with another set of bindings. > But it was determined that in fact this is a different device with a > different register set. > > From what I remember of dealing with Synopsys cores in the past, > these cores are highly configurable using their coreBuilder tools. So > while the other device might stem from the same initial core from > Synopsys, it was probably built with different design parameters > compared to the core that exists in the i.MX6. So in essence it is a > different device. > > >> patches >> 4-14 are out of scope for the media subsystem, > > Ok. I did submit patches 4-14 to the right set of folks. Should I just > drop this set in the next submission if they have not changed?
No, please keep them. Just make a note in the cover letter that they go through a different tree. I like seeing the whole set :-)
>> patches 20-25 and 27-34 >> are all staging (so fine to be merged from my point of view). >> >> I'm not sure if patch 26 (defconfig) should be applied while the imx >> driver is in staging. I would suggest that this patch is moved to the end >> of the series. > > Ok. > >> >> That leaves patches 15-19. I replied to patch 15 with a comment, patches >> 16-18 look good to me, although patches 17 and 18 should be combined >> to one >> patch since patch 17 won't compile otherwise. Any idea when the >> multiplexer is >> expected to be merged? (just curious) > > Philipp replied separately. > >> >> I would really like to get this merged for 4.13, so did I miss anything? >> From what I can tell it is really just an Ack for patch 2/34. > > Agreed.
Can you split off the TODO file in its own patch? It was buried in the big patch and I missed it because of that.
Take a look at Sakari's comment from today about another TODO item that probably should be in the TODO file.
Regards,
Hans
Regards,
Hans
| |