Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 27 May 2017 16:07:09 +0300 | Subject | Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure |
| |
On Sat, May 27, 2017 at 2:51 PM, Pali Rohár <pali.rohar@gmail.com> wrote: > object_id and notify_id are in one union structure and their meaning is > defined by flags. Therefore do not print notify_id for non-event block and > do not print object_id for event block. Remove also reserved member as it > does not have any defined meaning or type yet. > > As object_id and notify_id union members overlaps and have different types, > it caused that kernel print to dmesg binary data. This patch eliminates it.
> - pr_info("\tobject_id: %c%c\n", g->object_id[0], g->object_id[1]); > - pr_info("\tnotify_id: %02X\n", g->notify_id);
> - pr_info("\treserved: %02X\n", g->reserved);
Do we need this? Commit message doesn't clarify.
> + if (g->flags & ACPI_WMI_EVENT) > + pr_info("\tnotify_id: 0x%02X\n", g->notify_id); > + else
> + pr_info("\tobject_id: %c%c\n", g->object_id[0], g->object_id[1]);
If this can still contain non-printable characters the %*pE can help instead.
-- With Best Regards, Andy Shevchenko
| |