Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 26 May 2017 15:46:56 -0700 | Subject | Re: [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time() |
| |
Hi,
On Tue, May 23, 2017 at 2:51 PM, Matthias Kaehlcke <mka@chromium.org> wrote: > The function was added by commit e5d1367f17ba ("perf: Add cgroup > support") in 2011 and hasn't been used since then. Removing it fixes the > following warning when building with clang: > > kernel/events/core.c:696:19: error: unused function > 'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function] > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > kernel/events/core.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 6e75a5c9412d..9058fc7ca1fb 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event) > return 0; > } > > -static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event) > -{ > - return 0; > -} > - > static inline void update_cgrp_time_from_event(struct perf_event *event) > { > }
Definitely seems like no reason to keep this around. FWIW:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |