lkml.org 
[lkml]   [2017]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 03/27] thunderbolt: Do not try to read UID if DROM offset is read as 0
    Date
    At least Falcon Ridge when in host mode does not have any kind of DROM
    available and reading DROM offset returns 0 for these. Do not try to
    read DROM any further in that case.

    Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    Reviewed-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
    Reviewed-by: Michael Jamet <michael.jamet@intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/thunderbolt/eeprom.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c
    index 6392990c984d..e4e64b130514 100644
    --- a/drivers/thunderbolt/eeprom.c
    +++ b/drivers/thunderbolt/eeprom.c
    @@ -276,6 +276,9 @@ int tb_drom_read_uid_only(struct tb_switch *sw, u64 *uid)
    if (res)
    return res;

    + if (drom_offset == 0)
    + return -ENODEV;
    +
    /* read uid */
    res = tb_eeprom_read_n(sw, drom_offset, data, 9);
    if (res)
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-05-26 18:11    [W:4.268 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site