Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Thu, 25 May 2017 01:01:45 +0200 | Subject | Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" |
| |
On Wed, May 24, 2017 at 10:08 AM, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > Hi Rafael, > > On May 15 2017 or thereabouts, Rafael J. Wysocki wrote: >> >> >> Benjamin, my understanding is that this is the case, is it correct? >> >> > >> >> > That is correct. This patch I reverted introduces regression for professional >> >> > laptops that expect the LID switch to be reported accurately. >> >> >> >> And from a user's perspective, what does not work any more? >> > >> > If you boot or resume your laptop with the lid closed on a docking >> > station while using an external monitor connected to it, both internal >> > and external displays will light on, while only the external should. >> > >> > There is a design choice in gdm to only provide the greater on the >> > internal display when lit on, so users only see a gray area on the >> > external monitor. Also, the cursor will not show up as it's by default >> > on the internal display too. >> > >> > To "fix" that, users have to open the laptop once and close it once >> > again to sync the state of the switch with the hardware state. >> >> OK >> >> Yeah, that sucks. >> >> So without the Lv's patch the behavior (on the systems in question) is >> as expected, right? > > Would you agree to take both these reverts without Lv's ACK? We already > tried to explain for 2 weeks that they are valuable, but it seems we > can't make change his mind.
One of the reverts actually is already in (as a patch from Lv) and I'll most probably push the other one for -rc4 next week.
Thanks, Rafael
| |