Messages in this thread | | | From | Logan Gunthorpe <> | Date | Wed, 24 May 2017 16:09:06 -0600 | Subject | Re: [PATCH] um: add dummy ioremap and iounmap functions |
| |
On 24/05/17 04:05 PM, Al Viro wrote: >> I have designs to use these functions in scatterlist.c where they'd >> almost certainly never be called on the um architecture but it does need >> to compile. > > Then make it fail there.
Ok, will do. I'll send a v2 patch shortly.
> Incidentally, s390 has ioremap() only when CONFIG_PCI is set.
Hmm, ok, I'll take a peek. The kbuild robot never reported any build issues with that architecture. I did see exactly this on the tile architecture which I sent another patch for (that your feedback also applies to).
Thanks for the quick review and feedback,
Logan
| |