Messages in this thread | | | Subject | Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device | From | "Martin K. Petersen" <> | Date | Wed, 24 May 2017 15:11:48 -0400 |
| |
Johannes,
> When pci_enable_device() or pci_enable_device_mem() fail in > qla2x00_probe_one() we bail out but do a call to > pci_disable_device(). This causes the dev_WARN_ON() in > pci_disable_device() to trigger, as the device wasn't enabled > previously. > > So instead of taking the 'probe_out' error path we can directly return > *iff* one of the pci_enable_device() calls fails. > > Additionally rename the 'probe_out' goto label's name to the more > descriptive 'disable_device'.
Applied to 4.12/scsi-fixes. Thank you!
-- Martin K. Petersen Oracle Linux Engineering
| |