lkml.org 
[lkml]   [2017]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: CHIPPro NAND issue with 4.12 rc1
On Tue, May 23, 2017 at 10:05:14PM -0600, Angus Ainslie wrote:
> On 2017-05-23 13:52, Maxime Ripard wrote:
> >
> > Ok, good.
> >
> > If you unrevert those patches, and add clk_ignore_unused to the kernel
> > command line, is it still broken?
> >
> > Maxime
>
>
> If I use the clk_ignore_unused flag with the patches below then the kernel
> can boot and mount the nand.
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun5i.c
> b/drivers/clk/sunxi-ng/ccu-sun5i.c
> index 5c476f9..700944c 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun5i.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun5i.c
> @@ -251,7 +251,7 @@ static SUNXI_CCU_GATE(ahb_mmc1_clk, "ahb-mmc1",
> "ahb",
> static SUNXI_CCU_GATE(ahb_mmc2_clk, "ahb-mmc2", "ahb",
> 0x060, BIT(10), 0);
> static SUNXI_CCU_GATE(ahb_nand_clk, "ahb-nand", "ahb",
> - 0x060, BIT(13), 0);
> + 0x060, BIT(13), CLK_IS_CRITICAL);
> static SUNXI_CCU_GATE(ahb_sdram_clk, "ahb-sdram", "ahb",
> 0x060, BIT(14), CLK_IS_CRITICAL);
> static SUNXI_CCU_GATE(ahb_emac_clk, "ahb-emac", "ahb",

That doesn't really make much sense, clk_ignore_unused and
CLK_IS_CRITICAL are roughly doing the same thing

Could you paste the whole kernel logs?

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-05-24 08:35    [W:0.066 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site