lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 037/103] proc: Fix unbalanced hard link numbers
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit d66bb1607e2d8d384e53f3d93db5c18483c8c4f7 upstream.

    proc_create_mount_point() forgot to increase the parent's nlink, and
    it resulted in unbalanced hard link numbers, e.g. /proc/fs shows one
    less than expected.

    Fixes: eb6d38d5427b ("proc: Allow creating permanently empty directories...")
    Reported-by: Tristan Ye <tristan.ye@suse.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/proc/generic.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/proc/generic.c
    +++ b/fs/proc/generic.c
    @@ -469,6 +469,7 @@ struct proc_dir_entry *proc_create_mount
    ent->data = NULL;
    ent->proc_fops = NULL;
    ent->proc_iops = NULL;
    + parent->nlink++;
    if (proc_register(parent, ent) < 0) {
    kfree(ent);
    parent->nlink--;

    \
     
     \ /
      Last update: 2017-05-23 22:52    [W:4.361 / U:1.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site