lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 045/103] ext4 crypto: fix some error handling
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 4762cc3fbbd89e5fd316d6e4d3244a8984444f8d upstream.

    We should be testing for -ENOMEM but the minus sign is missing.

    Fixes: c9af28fdd449 ('ext4 crypto: don't let data integrity writebacks fail with ENOMEM')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/page-io.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ext4/page-io.c
    +++ b/fs/ext4/page-io.c
    @@ -492,7 +492,7 @@ int ext4_bio_write_page(struct ext4_io_s
    data_page = ext4_encrypt(inode, page, gfp_flags);
    if (IS_ERR(data_page)) {
    ret = PTR_ERR(data_page);
    - if (ret == ENOMEM && wbc->sync_mode == WB_SYNC_ALL) {
    + if (ret == -ENOMEM && wbc->sync_mode == WB_SYNC_ALL) {
    if (io->io_bio) {
    ext4_io_submit(io);
    congestion_wait(BLK_RW_ASYNC, HZ/50);

    \
     
     \ /
      Last update: 2017-05-23 22:49    [W:4.150 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site