lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 024/103] regulator: tps65023: Fix inverted core enable logic.
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Richard Cochran <rcochran@linutronix.de>

    commit c90722b54a4f5e21ac59301ed9a6dbaa439bdb16 upstream.

    Commit 43530b69d758328d3ffe6ab98fd640463e8e3667 ("regulator: Use
    regmap_read/write(), regmap_update_bits functions directly") intended
    to replace working inline helper functions with standard regmap
    calls. However, it also inverted the set/clear logic of the "CORE ADJ
    Allowed" bit. That patch was clearly never tested, since without that
    bit cleared, the core VDCDC1 voltage output does not react to I2C
    configuration changes.

    This patch fixes the issue by clearing the bit as in the original,
    correct implementation. Note for stable back porting that, due to
    subsequent driver churn, this patch will not apply on every kernel
    version.

    Fixes: 43530b69d758 ("regulator: Use regmap_read/write(), regmap_update_bits functions directly")
    Signed-off-by: Richard Cochran <rcochran@linutronix.de>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/regulator/tps65023-regulator.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/regulator/tps65023-regulator.c
    +++ b/drivers/regulator/tps65023-regulator.c
    @@ -311,8 +311,7 @@ static int tps_65023_probe(struct i2c_cl

    /* Enable setting output voltage by I2C */
    regmap_update_bits(tps->regmap, TPS65023_REG_CON_CTRL2,
    - TPS65023_REG_CTRL2_CORE_ADJ,
    - TPS65023_REG_CTRL2_CORE_ADJ);
    + TPS65023_REG_CTRL2_CORE_ADJ, 0);

    return 0;
    }

    \
     
     \ /
      Last update: 2017-05-23 22:47    [W:4.050 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site