lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5] kernfs: add exportfs operations
    Hello,

    On Mon, May 22, 2017 at 03:53:04PM -0700, Shaohua Li wrote:
    > The goal isn't to export kernfs to NFS. The intention is to make tracing cgroup
    > aware. To do this, tracing will record an id for cgroup and use the id to find
    > cgroup name later. The best id is the cgroup directory inode number. Further to
    > filter out stale cgroup directory, fhandle is the best to identify a cgroup. So
    > this is what this series try to do.

    Generally looks good to me. Had some review points in other replies.
    There is a related issue which can be a nice follow-up - replacing
    cgrp->id with kernfs's fid. cgrp->id is allocated on its own idr and
    its only use is to accelerate testing for ancestry and we can easily
    replace that with the unique file id.

    Thanks a lot!

    --
    tejun

    \
     
     \ /
      Last update: 2017-05-23 21:08    [W:3.100 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site