Messages in this thread | | | From | Bogdan Purcareata <> | Subject | RE: [PATCH 1/2] net: phy: Update get_phy_c45_ids for Cortina PHYs | Date | Tue, 23 May 2017 16:32:07 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Tuesday, May 23, 2017 7:04 PM > To: Bogdan Purcareata <bogdan.purcareata@nxp.com> > Cc: f.fainelli@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] net: phy: Update get_phy_c45_ids for Cortina PHYs > > On Tue, May 23, 2017 at 03:53:18PM +0000, Bogdan Purcareata wrote: > > Complete the work started by the following patches > > 5f6c99e0 net: phy: fix a bug in get_phy_c45_ids > > da1da284 net/phy: tune get_phy_c45_ids to support more c45 phy > > > > in order to properly get non-standard C45 10G PHY IDs (e.g. Cortina > > CS4340). > > At a first look, this seems to be a hack to work around a broken phy. > > Instead of this, can you use the ethernet-phy-id property in device > tree?
The patches mentioned in the commit message add _some_ support for the Cortina PHYs - mainly checking for devices at additional locations. Once they are found, the phy IDs must be read from custom locations. I followed the u-boot model [1].
I was aiming to patch the get_phy_c45_ids to fully handle the Cortina PHY scenario (right now, the support is only partial).
[1] http://code.metager.de/source/xref/denx/u-boot/drivers/net/phy/cortina.c#288
Thank you! Bogdan
| |