Messages in this thread Patch in this message | | | From | Dmitry Torokhov <> | Subject | [PATCH 3/8] firmware: vpd: avoid potential use-after-free when destroying section | Date | Tue, 23 May 2017 17:07:43 -0700 |
| |
We should not free info->key before we remove sysfs attribute that uses this data as its name.
Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/firmware/google/vpd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c index acf3f3cdc3f8..b3a6e918418b 100644 --- a/drivers/firmware/google/vpd.c +++ b/drivers/firmware/google/vpd.c @@ -157,8 +157,8 @@ static void vpd_section_attrib_destroy(struct vpd_section *sec) struct vpd_attrib_info *temp; list_for_each_entry_safe(info, temp, &sec->attribs, list) { - kfree(info->key); sysfs_remove_bin_file(sec->kobj, &info->bin_attr); + kfree(info->key); kfree(info); } } -- 2.13.0.219.gdb65acc882-goog
| |