lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel: Export mm_access
On Tue, 23 May 2017 16:17:29 -0400 Felix Kuehling <felix.kuehling@amd.com> wrote:

> From: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
>
> Exporting mm_access, which is required for implementing accelerated
> equivalents of process_vm_readv/process_vm_writev for GPU memory in KFD
> (AMD's GPU compute driver). This allows us to apply all the same remote
> process memory access policies.
>
> Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> Current KFD with AMD discrete GPU support is not yet upstream, but we
> are working on getting it upstream for 4.13 or 4.14 depending on how we
> line up with Dave Airlie's merge windows.
>
> For reference, recent releases of ROCm (AMD's Radeon Open Compute
> Platform software stack) with fully open-source user mode and kernel
> code can be found on GitHub:
> https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/tree/roc-1.5.0

Well if we're going to export it, I suppose we should actually document
it. Could you please include some commentary above mm_access() which
describes what it does, why it does it, return value, etc?

Then please include this patch in whatever tree contains the KFD code,
with my Acked-by: Andrew Morton <akpm@linux-foundation.org>.

> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1060,6 +1060,7 @@ struct mm_struct *mm_access(struct task_struct
> *task, unsigned int mode)
>
> return mm;
> }
> +EXPORT_SYMBOL_GPL(mm_access);
>
> static void complete_vfork_done(struct task_struct *tsk)
> {

fyi, your email client is word-wrapping the patches.

\
 
 \ /
  Last update: 2017-05-23 23:15    [W:0.043 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site